Update cake tools #2293
Merged
Update cake tools #2293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
martincostello
commented
Sep 17, 2024
•
martincostello
commented
- Bump xunit.runner.console to 2.9.2.
- Bump dotnet-stryker to 4.3.0.
martincostello
added
CI/build
dependencies
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2293 +/- ##
==========================================
- Coverage 85.40% 85.37% -0.03%
==========================================
Files 313 313
Lines 7467 7467
Branches 1126 1125 -1
==========================================
- Hits 6377 6375 -2
- Misses 745 746 +1
- Partials 345 346 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
Needs more mutants. |
martincostello
commented
Sep 18, 2024
| @@ -61,8 +61,7 @@ internal AddResiliencePipelineContext(ConfigureBuilderContext<TKey> registryCont | |||
| public TOptions GetOptions<[DynamicallyAccessedMembers(DynamicallyAccessedMemberTypes.PublicParameterlessConstructor)] TOptions>(string? name = null) | |||
| { | |||
| var monitor = ServiceProvider.GetRequiredService<IOptionsMonitor<TOptions>>(); | |||
|
|
|||
| return name == null ? monitor.CurrentValue : monitor.Get(name); | |||
| return monitor.Get(name); | |||
There was a problem hiding this comment.
Effectively duplicates the implementation the way it was.
- Bump xunit.runner.console to 2.9.2. - Bump dotnet-stryker to 4.2.0. - Remove redundant branch because when the key is null it uses the default key, which is what `CurrentValue` does anyway. - Assert that the correct options instance is retrieved. - Explicitly pass the configuration to stryker.
martincostello
force-pushed
the
bump-cake-tools
branch
from
1ffaf0b
to
2aec83a
Compare
Update to 4.3.0 which hopefully fixes the issues observed.
|
@joelhulen Just noticed that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.